Skip to content

London | 26-SDC-July | AYK| Sprint 1 | Individual shell tools exercises - #563

Open
sarawone wants to merge 10 commits into
CodeYourFuture:mainfrom
sarawone:AYK
Open

London | 26-SDC-July | AYK| Sprint 1 | Individual shell tools exercises#563
sarawone wants to merge 10 commits into
CodeYourFuture:mainfrom
sarawone:AYK

Conversation

@sarawone

@sarawone sarawone commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Exercise for the shell tools. Please kindly check and provide feedback.. Thank you so much.

@sarawone sarawone added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 8, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 8, 2026
@github-actions

This comment has been minimized.

Sign in to view
@sarawone sarawone added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 8, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 8, 2026
@github-actions

This comment has been minimized.

Sign in to view
@sarawone sarawone added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026
@sarawone sarawone added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026
@sarawone sarawone added NotCoursework Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 9, 2026
LonMcGregor
LonMcGregor reviewed Jul 13, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shell tools tasks and the number system tasks needs to be as separate PRs, can you check this?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
3 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@sarawone

sarawone commented Jul 22, 2026

Copy link
Copy Markdown
Author

eparate PRs, can you check this?

I have create one new PR for this .

@LonMcGregor

LonMcGregor commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Can you fix the title of the PR so the automated checks can run first?

@sarawone sarawone changed the title London | 26-SDC-July | AYK | Sprint1 | Module-Tool London | 26-SDC-July | AYK| Sprint 1 | Individual shell tools exercises Jul 27, 2026
@sarawone

sarawone commented Jul 27, 2026

Copy link
Copy Markdown
Author

Can you fix the title of the PR so the automated checks can run first?

I have fix the title of the PR. Thank you...

@LonMcGregor LonMcGregor added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
LonMcGregor
LonMcGregor reviewed Jul 28, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, but for the automated tests to pass, don't put a cd, just put the specific tool command instead. Can you make that change? Apologies for the delay in review

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 28, 2026
@sarawone

sarawone commented Jul 28, 2026

Copy link
Copy Markdown
Author

removed cd from the files.

@LonMcGregor LonMcGregor added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

Results of test:
Failed awk/script-05.sh, please check
Failed cat/script-01.sh, please check
Failed cat/script-02.sh, please check
Failed cat/script-03.sh, please check
Failed ls/script-02.sh, please check
Failed ls/script-04.sh, please check
Failed sed/script-02.sh, please check
Failed sed/script-04.sh, please check
Failed sed/script-05.sh, please check
Failed sed/script-06.sh, please check
Failed wc/script-01.sh, please check
Failed wc/script-02.sh, please check
Failed wc/script-03.sh, please check
You passed 17/30 tasks.

@LonMcGregor

LonMcGregor commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

It looks like you've got the right approach for a lot of these tasks, but for the checks to pass you need to build some scripts that will work when you run the script from the directory it is in.

E.g. when testing I see this error:

individual-shell-tools/wc$ ./script-01.sh 
wc: helper-3.txt: No such file or directory

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarawone @LonMcGregor